通过环境变量支持自定义service name #293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 70.85% 70.76% -0.10%
==========================================
Files 34 34
Lines 2035 2035
==========================================
- Hits 1442 1440 -2
- Misses 480 482 +2
Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks for your contribution @williamfzc I am thinking that it's better to provide some explanations for this enhancement. And here seems a proper place. Of course, you can submit another PR if you will. Thanks again. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CarlJi, williamfzc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
见 #199 #292
/assign @memoryliu
/approve